Remote test timeout #51934
Remote test timeout #51934
Conversation
They aren't removed from the list when not pending, so this is confusing.
|
I'm pretty confident that all the Firefox changes are existing intermittents. |
Otherwise we end up not calling the done callbacks, which in the case of remote tests means that we don't notify the parent that the tests are done, so we can't end the test run, and eventually time out. This wastes a huge amount of time in CI.
jgraham
force-pushed
the
remote_test_timeout
branch
from
2c82bb6 to
0e4ea34
Compare
|
There are no reviewers for this pull request besides its author. Please reach out on the chat room to get help with this. Thank you! |
|
I don't know why I can't find the Chrome or Firefox Android runs on wpt.fyi |
Ms2ger
left a comment
Ms2ger
left a comment
There was a problem hiding this comment.
Seems okay based on a quick look
resources/testharness.js
Outdated
|
|
||
| Tests.prototype.push = function(test) | ||
| { | ||
| if (this.phase == this.phases.COMPLETE) { |
There was a problem hiding this comment.
We mostly use strict equality in this file, so we should probably remain consistent with that.
This change also isn't immediately obviously part of fixing an off-by-one error.
https://wpt.fyi/runs?sha=0e4ea3448ac04586943389df31d9a9c091377cef&max-count=100&from=2025-04-01T00%3A00&product=chrome_android&product=firefox_android&product=chrome&product=firefox&product=safari shows the Chrome run, and https://wpt.fyi/status shows run 5172680024391680 as pending — which may well be the Firefox Android run? Why that is stuck in pending is a good question. |
No description provided.