refactor(linalg): de-duplicate linalg module (#47)#66
Merged
Conversation
Fifth de-duplication step of #47, following the established pattern. - src/linalg/linalg.ts: replace the type-only stub with the REAL implementation moved verbatim from the monolith (JacobiImpl, JacobiSVDImpl, lu_solve, cholesky_solve, svd_decompose, svd_solve, svd_invert, eigenVV). Imports swap/hypot from ./linalg_base and matmath — both already real modules. - src/jsfeatNext.ts: shrinks by ~740 lines (largest single extraction). Verified behavior-preserving: tsc --noEmit clean; npm test 57/57 (6 parity tests pin linalg: LU, Cholesky, SVD x3, eigenVV vs original jsfeat); UMD bundle smoke-checked (instanceof, static inheritance, lu_solve on an SPD system). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
kalwalt
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth slice of #47 — the largest single extraction (~740 lines). Fresh branch off the integration branch.
What changed
src/linalg/linalg.ts— type-only stub replaced by the real implementation, verbatim from the monolith:JacobiImpl,JacobiSVDImpl,lu_solve,cholesky_solve,svd_decompose,svd_solve,svd_invert,eigenVV. It importsswap/hypotfrom./linalg_baseandmatmath— both already real modules, no aggregator references needed.src/jsfeatNext.ts— down another ~740 lines (monolith now ~1,300 of the original ~3,900).Verification
tsc --noEmit→ cleannpm test→ 57/57 — six parity tests pin this module directly (LU, Cholesky, SVD ×3, eigenVV vs original jsfeat, SVD/eigen matched to 4 decimals)instanceofchain, static inheritance,lu_solveon an SPD systemdist//types/untouched (rebuilt when the integration branch merges todev)Advances #47. Remaining:
orb→yape06→motion_estimator(+ inline kernels → tightenscore.tsanyslots) →optical_flow_lk.🤖 Generated with Claude Code