refactor(yape06): de-duplicate yape06 module (#47)#68
Merged
Conversation
Seventh de-duplication step of #47, following the established pattern. - src/yape06/yape06.ts: replace the type-only stub with the REAL implementation moved verbatim from the monolith (detect + laplacian / min-eigen-value thresholds). Imports compute_laplacian and hessian_min_eigen_value from ./yape06_utils (already a real module). - src/jsfeatNext.ts: shrinks by ~85 lines. Verified behavior-preserving: tsc --noEmit clean; npm test 57/57 (the yape06 parity test pins detect() against original jsfeat); UMD bundle smoke-checked (instanceof, default thresholds, detection on a synthetic image). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
kalwalt
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seventh slice of #47, fresh off the integration branch.
What changed
src/yape06/yape06.ts— type-only stub replaced by the real implementation, verbatim from the monolith (detect,laplacian_threshold/min_eigen_value_thresholdfields). Importscompute_laplacian/hessian_min_eigen_valuefrom./yape06_utils, already a real module. No aggregator references needed.src/jsfeatNext.ts— ~85 lines removed. Onlymotion_estimator(+ inline kernels) andoptical_flow_lkremain inline.Verification
tsc --noEmit→ cleannpm test→ 57/57 (the yape06 parity test pinsdetect()against original jsfeat)dist//types/untouched (rebuilt when the integration branch merges todev)Advances #47. Remaining:
motion_estimator(+motion_model/affine2d/homography2d, which also tightens theanyslots incore.ts) →optical_flow_lk.🤖 Generated with Claude Code