Merge videoUploading samples together#364
Merged
Merged
Conversation
austinEng
reviewed
Mar 5, 2024
austinEng
approved these changes
Mar 5, 2024
Collaborator
Author
|
@austinEng Unlike my local environment, https://webgpu.github.io/webgpu-samples/samples/videoUploadingWebCodecs does not redirect to https://webgpu.github.io/webgpu-samples/samples/videoUploading?videoSource=videoFrame. Do you know what is happening? |
Collaborator
Author
|
Could it be because I missed "/webgpu-samples/" in redirection URLs? |
Merged
Collaborator
Author
|
@austinEng I've just sent #365 for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges both videoUploading and videoUploadingWebCodecs samples together as there's not much value in having both when only the external texture source changes. Note that I set up a redirect so that existing links to videoUploadingWebCodecs still work properly.
See diff at https://www.diffchecker.com/FUiV227s/