Skip to content

Fix redirect for videoUploadingWebCodecs#367

Merged
austinEng merged 1 commit into
webgpu:mainfrom
austinEng:redirect
Mar 5, 2024
Merged

Fix redirect for videoUploadingWebCodecs#367
austinEng merged 1 commit into
webgpu:mainfrom
austinEng:redirect

Conversation

@austinEng
Copy link
Copy Markdown
Collaborator

Next.js redirects don't work for static-site generation because it can't generate a .html file for the page.

Follow-up on #364 and #365

Next.js redirects don't work for static-site generation.
@austinEng austinEng enabled auto-merge (squash) March 5, 2024 21:02
@austinEng austinEng requested a review from kainino0x March 5, 2024 23:09
@austinEng austinEng merged commit 95137ca into webgpu:main Mar 5, 2024
@kainino0x
Copy link
Copy Markdown
Collaborator

kainino0x commented Mar 6, 2024

@austinEng
Copy link
Copy Markdown
Collaborator Author

ugh yea.
somehow it still doesn't work.

Deployed gh page:
https://github.com/webgpu/webgpu-samples/blob/gh-pages/samples/videoUploadingWebCodecs.html

has

<meta http-equiv="refresh" content="0; url=/webgpu-samples/samples/videoUploading?videoSource=videoFrame"/>

in it

but yea, I get redirected to
/samples/videoUploading?videoSource=videoFrame instead

@austinEng
Copy link
Copy Markdown
Collaborator Author

OH. I see. in the sources panel, the redirect url is correct.

but if I break in DOMWindow.load - before redirect happens, it is wrong.

Basically, it seem JS is loading, changing the meta tag, and then it redirects... :-/

@beaufortfrancois
Copy link
Copy Markdown
Collaborator

Thank you @austinEng and @kainino0x for addressing this issue!

@beaufortfrancois beaufortfrancois mentioned this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants