Fix redirect for videoUploadingWebCodecs#367
Merged
Merged
Conversation
Next.js redirects don't work for static-site generation.
kainino0x
approved these changes
Mar 5, 2024
Collaborator
Collaborator
Author
|
ugh yea. Deployed gh page: has in it but yea, I get redirected to |
Collaborator
Author
|
OH. I see. in the sources panel, the redirect url is correct. but if I break in DOMWindow.load - before redirect happens, it is wrong. Basically, it seem JS is loading, changing the meta tag, and then it redirects... :-/ |
Merged
Collaborator
|
Thank you @austinEng and @kainino0x for addressing this issue! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next.js redirects don't work for static-site generation because it can't generate a .html file for the page.
Follow-up on #364 and #365