Dev playground locally track categories #5501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This works for me, and the good thing is that this was created using Compose. Please fix the single-line issue in the input fields. |
…rack-categories # Conflicts: # app/src/main/java/org/wikipedia/settings/dev/playground/CategoryDeveloperPlayGroundViewModel.kt
cooltey
requested changes
May 2, 2025
Collaborator
cooltey
left a comment
cooltey
left a comment
There was a problem hiding this comment.
All looks good, some minor improvements can be made:
- When it's in landscape mode, the screen is not scrollable.
- Can we have default values in the input fields (Year: 2025, Number of Rows: 5...etc)
…s default value to year outline Text Field
dbrant
pushed a commit
that referenced
this pull request
May 8, 2025
* - creates a new category table and adds entity and DAO class - adds logic to insertOrIncrement category count and deleteAll categories - adds migration logic for db - adds a new service call for fetching categories * - fixes lint issues * - adds room transaction to insert or increment the count - adds a query to get yearly categories by count descending order - updates category date column to year * - adds developer preference for categories * - updates database - code fixes - adds recurring task to delete Category data older than two years every six month - removes developer preferences * - removes unused class and dev print statement * - code fixes * - lint fixes * - schema revert * - code fixes * - code fixes * Dev playground locally track categories (#5501) * - adds playground for categories * - update copy * - code fixes * - adds scroll support by adding a dynamic fix height to table and adds default value to year outline Text Field * - lint fixes * - capitalizes table name in sql migration query * Follow up: Category dev playground (#5526) * WikiGames: Database table for the game history (#5510) * WikiGames: Database table for the game history * Lint * Create enum classes * last game * Update package * Code tuned up and migration * Lint * Add preference for first played snackbar * Lint * Refine migration * Clear old preference after migration * Fix db migration --------- Co-authored-by: Cooltey Feng <cfeng@wikimedia.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds a dev View to test categories functionality. To access go to developer settings and search "category" or scroll down to the bottom.
Preview