Skip to content

Conversation

@cooltey
Copy link
Collaborator

@cooltey cooltey commented Apr 30, 2025

What does this do?

Migrate the game data from Prefs to a database table.

Please note this PR is on top of #5489

Phabricator:
https://phabricator.wikimedia.org/T392362

@cooltey cooltey added the WIP Work in progress label Apr 30, 2025
@cooltey cooltey added Ready to merge PR passed design signoff and ready to be merged. and removed WIP Work in progress labels May 7, 2025
@Williamrai
Copy link
Collaborator

Switched branch from main to WikiGames db branch and Got this error.
error1

@cooltey
Copy link
Collaborator Author

cooltey commented May 7, 2025

Switched branch from main to WikiGames db branch and Got this error. error1

Thanks and fixed!

Copy link
Collaborator

@Williamrai Williamrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@dbrant dbrant merged commit 8203efc into locally-track-categories May 8, 2025
1 check passed
@dbrant dbrant deleted the wikigames-db branch May 8, 2025 19:15
dbrant pushed a commit that referenced this pull request May 8, 2025
* -  creates a new category table and adds entity and DAO class
- adds logic to insertOrIncrement category count and deleteAll categories
- adds migration logic for db
- adds a new service call for fetching categories

* - fixes lint issues

* - adds room transaction to insert or increment the count
- adds a query to get yearly categories by count descending order
- updates category date column to year

* - adds developer preference for categories

* - updates database
- code fixes
- adds recurring task to delete Category data older than two years every six month
- removes developer preferences

* - removes unused class and dev print statement

* - code fixes

* - lint fixes

* - schema revert

* - code fixes

* - code fixes

* Dev playground locally track categories (#5501)

* - adds playground for categories

* - update copy

* - code fixes

* - adds scroll support by adding a dynamic fix height to table and adds default value to year outline Text Field

* - lint fixes

* - capitalizes table name in sql migration query

* Follow up: Category dev playground (#5526)

* WikiGames: Database table for the game history (#5510)

* WikiGames: Database table for the game history

* Lint

* Create enum classes

* last game

* Update package

* Code tuned up and migration

* Lint

* Add preference for first played snackbar

* Lint

* Refine migration

* Clear old preference after migration

* Fix db migration

---------

Co-authored-by: Cooltey Feng <cfeng@wikimedia.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge PR passed design signoff and ready to be merged.

Development

Successfully merging this pull request may close these issues.

3 participants