chore: use detekt rule for ui wait in test core (WPB-21886)

[yamilmedina]

https://wearezeta.atlassian.net/browse/WPB-21886

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Follow up final for standard api in testing framework.

• chore: remove testing helpers duplicated code and move into testSupport (WPB-21886) #4752
• chore: migrate to kotlin Duration usage for polling, timeout units for test framework (WPB-21886) #4783

In this PR.

• Remove the temporary gradle task to check for wait code not according to guidelines
• Migrate to custom wire detekt rule usage.

Attachments

View of failure by detekt

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.13%. Comparing base (c88cee4) to head (3644ce2).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4784   +/-   ##
========================================
  Coverage    51.13%   51.13%           
========================================
  Files          610      610           
  Lines        21089    21089           
  Branches      3399     3399           
========================================
  Hits         10783    10783           
  Misses        9291     9291           
  Partials      1015     1015           

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88cee4...3644ce2. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud