chore: migrate to kotlin Duration usage for polling, timeout units for test framework (WPB-21886)#4783
Merged
Merged
Conversation
MohamadJaara
approved these changes
May 5, 2026
yamilmedina
changed the title
yamilmedina
changed the title
….2 (#4706) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Oussama Hassine <oussama.has100@gmail.com>
yamilmedina
requested review from
Garzas,
alexandreferris,
saleniuk and
typfel
and removed request for
a team
|
emmaoke-w
approved these changes
May 5, 2026
Contributor
emmaoke-w
left a comment
emmaoke-w
left a comment
There was a problem hiding this comment.
Thanks for the refactoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-21886
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Follow up on:
In order to have a better API for devs using the framework and make the testing API stable we are improving the code and refactoring to reflect a less verbose and reduce duplicated code
Solutions
Deprecate time unit representations in numeric value and use Kotlin Duration.
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.