Skip to content

feat: create new meeting [WPB-25677] - #5117

Merged
saleniuk merged 8 commits into
developfrom
feat/create-meeting
Jul 31, 2026
Merged

feat: create new meeting [WPB-25677]#5117
saleniuk merged 8 commits into
developfrom
feat/create-meeting

Conversation

@saleniuk

@saleniuk saleniuk commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25677


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Creating a new meeting, both "schedule" and "meet now".

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Open dev-debug build, go to "meetings" tab, click "new" and create a new meeting.

Attachments (Optional)

Screen_recording_20260730_160804.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 166 tests  +2   2 166 ✅ +2   2m 2s ⏱️ -22s
  235 suites ±0       0 💤 ±0 
  235 files   ±0       0 ❌ ±0 

Results for commit dd647d0. ± Comparison against base commit 54b093c.

This pull request removes 3 and adds 5 tests. Note that renamed tests count towards both.
com.wire.android.feature.meetings.mapper.MeetingMapperTest ‑ givenMeetingHasNoEndTime_whenMappingToMeetingItem_thenStatusIsOngoing()
com.wire.android.feature.meetings.ui.create.NewMeetingViewModelTest ‑ givenValidData_whenCreateMeetingIsCalled_thenSuccessActionIsSent()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenFutureMeeting_andSelfUserIsMember_whenObserving_thenDeleteForMeIsAvailable()
com.wire.android.feature.meetings.ui.create.NewMeetingViewModelTest ‑ givenCreationFails_whenCreateMeetingIsCalled_thenCreationErrorIsShownAndSuccessActionIsNotSent()
com.wire.android.feature.meetings.ui.create.NewMeetingViewModelTest ‑ givenMeetNowTypeWithValidData_whenCreateMeetingIsCalled_thenMeetingIsCreatedAndSuccessActionIsSent()
com.wire.android.feature.meetings.ui.create.NewMeetingViewModelTest ‑ givenScheduleTypeWithInvalidTimes_whenCreateMeetingIsCalled_thenTimeErrorIsShownAndMeetingIsNotCreated()
com.wire.android.feature.meetings.ui.create.NewMeetingViewModelTest ‑ givenScheduleTypeWithValidData_whenCreateMeetingIsCalled_thenMeetingIsCreatedAndSuccessActionIsSent()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenFutureMeeting_andSelfUserIsMember_whenObserving_thenDeleteIsNotAvailable()

♻️ This comment has been updated with latest results.

@pull-request-size pull-request-size Bot added size/M and removed size/S labels Jul 30, 2026
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.61538% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.01%. Comparing base (54b093c) to head (dd647d0).

Files with missing lines Patch % Lines
...id/feature/meetings/ui/MeetingsViewModelFactory.kt 0.00% 5 Missing ⚠️
.../feature/meetings/ui/create/NewMeetingViewModel.kt 89.28% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5117      +/-   ##
===========================================
+ Coverage    49.96%   50.01%   +0.04%     
===========================================
  Files          666      666              
  Lines        24364    24394      +30     
  Branches      3781     3784       +3     
===========================================
+ Hits         12173    12200      +27     
- Misses       11068    11072       +4     
+ Partials      1123     1122       -1     
Files with missing lines Coverage Δ
...e/android/feature/meetings/mapper/MeetingMapper.kt 73.17% <100.00%> (+8.46%) ⬆️
...wire/android/feature/meetings/model/MeetingItem.kt 91.17% <100.00%> (ø)
...d/feature/meetings/ui/list/MeetingListViewModel.kt 57.89% <100.00%> (ø)
...meetings/ui/options/MeetingOptionsMenuViewModel.kt 78.18% <100.00%> (ø)
.../feature/meetings/ui/create/NewMeetingViewModel.kt 86.20% <89.28%> (+0.94%) ⬆️
...id/feature/meetings/ui/MeetingsViewModelFactory.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b093c...dd647d0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@MohamadJaara
MohamadJaara added this pull request to the merge queue Jul 31, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk
saleniuk added this pull request to the merge queue Jul 31, 2026
Merged via the queue into develop with commit fc753ec Jul 31, 2026
22 checks passed
@saleniuk
saleniuk deleted the feat/create-meeting branch July 31, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants