Skip to content

fix: server time delta not used in new sync - WPB-18321#3230

Merged
jullianm merged 5 commits into
release/cycle-4.0from
fix/server-time-delta-not-used-in-new-sync
Jun 20, 2025
Merged

fix: server time delta not used in new sync - WPB-18321#3230
jullianm merged 5 commits into
release/cycle-4.0from
fix/server-time-delta-not-used-in-new-sync

Conversation

@jullianm
Copy link
Copy Markdown
Contributor

@jullianm jullianm commented Jun 20, 2025

BugWPB-18321 [iOS] NSE calls timed out still passing through, server time delta not updated

Issue

This PR aims at aligning with legacy code on the serverTimeDelta usage, specifically:

1/ In NSE, we don't rely on serverTimeDelta to check if a calling event is timed out. (see legacy NotificationSession)

2/ Server time delta value is not updated upon receiving update events envelopes, we should update the value as soon as we get an envelope (see legacy NotificationStreamAsync)

Testing

N/A

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm jullianm marked this pull request as ready for review June 20, 2025 11:04
@jullianm jullianm requested review from johnxnguyen and netbe June 20, 2025 11:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 20, 2025

Test Results

5 047 tests   5 020 ✅  5m 14s ⏱️
  728 suites     27 💤
    8 files        0 ❌

Results for commit 27e0240.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datadog-wireapp
Copy link
Copy Markdown

datadog-wireapp Bot commented Jun 20, 2025

Datadog Report

Branch report: fix/server-time-delta-not-used-in-new-sync
Commit report: be1c6d0
Test service: wire-ios-mono

✅ 0 Failed, 5020 Passed, 27 Skipped, 1m 49.14s Total Time

@jullianm jullianm enabled auto-merge (squash) June 20, 2025 12:08
Comment thread WireAPI/Sources/WireAPI/Models/UpdateEvent/TimestampedUpdateEventEnvelope.swift Outdated
@jullianm jullianm merged commit c2c69af into release/cycle-4.0 Jun 20, 2025
15 checks passed
@jullianm jullianm deleted the fix/server-time-delta-not-used-in-new-sync branch June 20, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants