fix: server time delta not used in new sync - WPB-18321#3234
Merged
jullianm merged 1 commit intoJun 20, 2025
Merged
Conversation
Contributor
Author
Test Results5 107 tests 5 080 ✅ 6m 18s ⏱️ Results for commit 34ff6b7. ♻️ This comment has been updated with latest results. |
9e25d61 to
34ff6b7
Compare
caldrian
approved these changes
Jun 20, 2025
jullianm
approved these changes
Jun 20, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
Issue
This PR aims at aligning with legacy code on the
serverTimeDeltausage, specifically:1/ In NSE, we don't rely on
serverTimeDeltato check if a calling event is timed out. (see legacyNotificationSession)2/ Server time delta value is not updated upon receiving update events envelopes, we should update the value as soon as we get an envelope (see legacy
NotificationStreamAsync)Testing
N/A
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: