Skip to content

fix: server time delta not used in new sync - WPB-18321#3234

Merged
jullianm merged 1 commit into
release/cycle-4.1from
fix/server-time-delta-not-used-in-new-sync-cherry-pick
Jun 20, 2025
Merged

fix: server time delta not used in new sync - WPB-18321#3234
jullianm merged 1 commit into
release/cycle-4.1from
fix/server-time-delta-not-used-in-new-sync-cherry-pick

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-18321 [iOS] NSE calls timed out still passing through, server time delta not updated

Issue

This PR aims at aligning with legacy code on the serverTimeDelta usage, specifically:

1/ In NSE, we don't rely on serverTimeDelta to check if a calling event is timed out. (see legacy NotificationSession)

2/ Server time delta value is not updated upon receiving update events envelopes, we should update the value as soon as we get an envelope (see legacy NotificationStreamAsync)

Testing

N/A

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm jullianm changed the base branch from develop to release/cycle-4.1 June 20, 2025 15:55
@jullianm jullianm changed the base branch from release/cycle-4.1 to develop June 20, 2025 15:55
@jullianm jullianm changed the base branch from develop to release/cycle-4.1 June 20, 2025 15:56
@jullianm jullianm closed this Jun 20, 2025
@jullianm jullianm deleted the fix/server-time-delta-not-used-in-new-sync-cherry-pick branch June 20, 2025 16:00
@caldrian caldrian restored the fix/server-time-delta-not-used-in-new-sync-cherry-pick branch June 20, 2025 16:02
@caldrian caldrian reopened this Jun 20, 2025
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented Jun 20, 2025

Test Results

5 107 tests   5 080 ✅  6m 18s ⏱️
  737 suites     27 💤
    8 files        0 ❌

Results for commit 34ff6b7.

♻️ This comment has been updated with latest results.

@caldrian caldrian force-pushed the fix/server-time-delta-not-used-in-new-sync-cherry-pick branch from 9e25d61 to 34ff6b7 Compare June 20, 2025 16:03
@jullianm jullianm enabled auto-merge (squash) June 20, 2025 16:05
@jullianm jullianm merged commit 036ad99 into release/cycle-4.1 Jun 20, 2025
15 checks passed
@jullianm jullianm deleted the fix/server-time-delta-not-used-in-new-sync-cherry-pick branch June 20, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants