Revert change in spelling of validateSAML{e,E}mails feature. - #4629
Merged
Conversation
zebot
added
the
ok-to-test
stefanwire
approved these changes
Jun 26, 2025
fisx
force-pushed
the
WPB-18471-fix-feature-spelling-again
branch
from
June 26, 2025 12:46
fdbe404 to
474661f
Compare
If we want to do this, we also need to version-control the response of `GET /v8/feature-configs` (can be done) and events (can also be done, but we're not currently doing that anywhere).
fisx
force-pushed
the
WPB-18471-fix-feature-spelling-again
branch
from
June 26, 2025 12:48
474661f to
65aa5e6
Compare
supersven
reviewed
Jun 26, 2025
supersven
approved these changes
Jun 26, 2025
supersven
left a comment
supersven
left a comment
Contributor
There was a problem hiding this comment.
I'm wondering if we cannot provide a golden test to guard against such issues in future? 🤔
Contributor
Author
see today's watercooler discussion :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We missed two details when "fixing" this: (1) we broke
GET /v8/feature-configsbecause we forgot to version-control the response body; (2) events.Until we have answers to these two points, I'll revert this and we'll keep the typo for backwards compatibility.
Checklist
changelog.d