build: envoy gateway support (helm) [WPB-24493] - #21860
Merged
Merged
Conversation
In general we wish to switch from ingress-nginx to envoy-gateway. This has already been added as an option when the webapp is installed as part of the wire-server bundle (see wireapp/wire-server#5150 and related PRs). But when using this chart standalone, it also needs to be added here. Ticket: https://wearezeta.atlassian.net/browse/WPB-24493
jschaul
added
deploy-with-argocd-alt
deploy-with-argocd-envoy
and removed
deploy-with-argocd-alt
labels
jschaul
marked this pull request as ready for review
July 21, 2026 14:04
jschaul
requested review from
arjita-mitra,
e-maad,
ikotarac,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
July 21, 2026 14:04
siberijah
previously approved these changes
Jul 22, 2026
siberijah
left a comment
siberijah
left a comment
Contributor
There was a problem hiding this comment.
I think yes it's better to use this approach, because it covers all three: nginx, envoy and the weighted based dns
screendriver
requested changes
Jul 22, 2026
screendriver
enabled auto-merge
July 23, 2026 05:17
screendriver
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general we wish to switch from ingress-nginx to envoy-gateway. This has already been added as an option when the webapp is installed as part of the wire-server bundle (see wireapp/wire-server#5150
and related PRs). But when using this chart standalone, it also needs to be added here.
Ticket: https://wearezeta.atlassian.net/browse/WPB-24493
This PR goes beyond the minimal needed work though, and also does these things:
ListenerSets. It's a newer object available since a few months, that makes it easier to share one gateway and EnvoyProxy for different domains, and define the ListernerSet / domains in the chart / overrides, without having to touch any infra.Deployments
https://argocd.apps-staging.ops.zinfra.io/applications/argo-cd/webapp-pr-21860 using these overrides and is available under https://webapp-pr-21860.apps-staging.wire.link
ingress: enabled: truetorouting: enabled: true / mode: nginxbut I believe the standalone webapp is not being used/deployed anywhere except through argo manifests (which is updated alongside this PR)Based on the the two modes there's a second "migration" mode which sets two extra annotations and then allows for a weighted DNS cutover without downtime: