Fix Spinner Ripple Effect in WCMaterialOutlinedSpinnerView.

[Akshaykomar890]

Fixes #5463

Disabled Hint: Set hintEnabled="false" in the WCMaterialOutlinedSpinnerView style to prevent the floating hint from occupying space and causing unintended ripple effects in the layout.

Before:

After:

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

[malinajirka]

Thank you so much @Akshaykomar890!

It wouldn't have crossed my mind this was caused by the hint, good catch! Seeing it now it makes total sense.

This change unfortunately breaks all the spinners that are setting a hint. For example:

Before	After

Steps to reproduce:

1. Tap on Products
2. Tap on Plus icon
3. Tap on Simple Subscription product
4. Tap on Add Price

Understanding the reason now, I can't think of a solution. Update: Perhaps we could create a custom background-ripple drawable with top padding, wdyt? I'm not sure whether it'd work as expected for different font-size(accessibility settings).

What about you, do you have some ideas?

[Akshaykomar890]

Hi @malinajirka ,

Thank you for pointing this out and for the detailed steps to reproduce the issue.

You're absolutely right that we can try creating a custom ripple with top padding. However, I believe it might not be fully stable across different font sizes and accessibility settings. While it's worth exploring,

I have another approach in mind:
Alternatively, we can leverage Material 3 by using:
https://github.com/material-components/material-components-android/blob/master/docs/components/Menu.md
<com.google.android.material.textfield.TextInputLayout
android:id="@+id/menu"
style="@style/Widget.Material3.TextInputLayout.FilledBox.ExposedDropdownMenu" >

this approach address issue without introducing instability. Let me know what you think, and I’m happy to refine the solution further.

[malinajirka]

Thanks @Akshaykomar890, replacing all the components with different components introduces a risk of regression which is IMO not worth it for such a small UI glitch most users won't even notice. I'd suggest either testing the approach with padding (it doesn't need to necessarily be perfect, as long as it's an improvement) or marking this issues as won't fix. What are your thoughts on all this?

[Akshaykomar890]

Thanks for your detailed feedback @malinajirka I completely understand the concern about regression risks. I'll test the padding adjustment approach and see if it provides a noticeable improvement. If the results aren't significant, I'm fine with marking this as "Won't Fix" for now. Thanks again.

[Akshaykomar890]

hello @malinajirka
I’ve tried the custom padding approach and added a commit with the changes. Could you please check if it meets the criteria? I believe this should improve the ripple effect without introducing any major issues.

You can find the commit here:e0599ff

I’ve tested it both with and without hints, and it’s working as expected in both cases.

Looking forward to hearing your thoughts!

[wpmobilebot]

Version 21.4 has now entered code-freeze, so the milestone of this PR has been updated to 21.5.

[malinajirka]

Thanks for following up on this @Akshaykomar890!

I’ve tested it both with and without hints, and it’s working as expected in both cases.

Nice, thanks for sharing what you tested!

I also tested light/dark mode and different font size and it all looks good to me. It's tiny bit off with custom font sizes as we anticipated, but it's still an improvement compared to the previous state.

Thank you for contributing and congrats on your first merged PR in this repo! 🚢

[Akshaykomar890]

Thank you so much @malinajirka for testing it thoroughly. I'm glad the changes have improved the previous state, and it’s exciting to contribute to the repo. I thankful for your guidance and support throughout the process.

Should I wait for this PR to merge, or can I start working on a new issue in the meantime?
Looking forward to contributing more.

[malinajirka]

Should I wait for this PR to merge, or can I start working on a new issue in the meantime? Looking forward to contributing more.

Nice, thank you! Feel free to pick up any amount of issues in parallel you like.