-
Notifications
You must be signed in to change notification settings - Fork 120
Closed
Labels
feature: loginRelated to any part of the log in or sign in flow, or authentication.Related to any part of the log in or sign in flow, or authentication.type: enhancementA request for an enhancement.A request for an enhancement.
Description
Is your feature request related to a problem? Please describe.
To prepare the Authenticator for the Unified Login & Signup feature, first we need to break apart the storyboard segues and navigate to the views programmatically.
Describe the solution you'd like
Let's break apart the segues in the Authenticator storyboards.
2. Remove known segues. Replace with navController.
- remove .showEmailLogin [Auth] Remove the
.showLoginEmailsegue and navigate programmatically #2007 - remove .showSignupMethod
- remove .showSigninV2
- remove .showGoogle [Auth] Remove the
.showGooglesegue and navigate programmatically #2031 - remove .showURLUsernamePassword
- remove .showWPUsernamePassword UL&S: Remove .showWPUsernamePassword segue #2151
- remove .showSelfHostedLogin
- remove .showWPComLogin UL&S: Remove .showWPComLogin segue #2269
- remove .startMagicLinkFlow UL&S: Remove .startMagicLinkFlow segue #2201
- remove .showMagicLink
- remove .showLinkMailView [Auth] Remove the
.showLinkMailViewsegue and navigate programmatically #2023 - remove .show2FA [Auth] Remove the
.show2FAsegue and navigate programmatically #2071 - remove .showDomains Dashboard: Not loading data after login #260
- remove .showCreateSite Alternative login with site URL #263
- remove .showSignupEmail
- remove .showUsernames
- remove .showLoginMethod UL&S: Remove .showLoginMethods segue from Site Address VC #2244
- some segues were added manually (didn't use the enum) and need changes (these were discovered when testing a removed segue and a crash happened during the navigation attempt)
Describe alternatives you've considered
Detailed information on the alternatives can be found at pbArwn-2W-p2
Additional context
n / a
Metadata
Metadata
Assignees
Labels
feature: loginRelated to any part of the log in or sign in flow, or authentication.Related to any part of the log in or sign in flow, or authentication.type: enhancementA request for an enhancement.A request for an enhancement.