-
Notifications
You must be signed in to change notification settings - Fork 120
[Auth] Remove the .showLoginEmail segue and navigate programmatically
#2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TIL that Cocoapods does not like our beta versions and will ignore newer beta versions.
.showLoginEmail segue and navigate programmatically
|
@mindgraffiti It looks like there are conflicts in |
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
@shiki fixed 🙂 |
shiki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mindgraffiti! I have a question about the pod versions.
- Tested login with site address
- Tested login with Jetpack
- Quickly glanced at wordpress-mobile/WordPressAuthenticator-iOS#207 to see what's changed
Also force cocoapods to pick up the latest Authenticator changes, by using the latest commit
shiki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Thuy! Thank you for reverting the Podfile change. And sorry for the delay!
![]()
|
Thank you @shiki ! |
Ref. #2003.
In this PR
.showLoginEmailTo Test
rake dependenciesDo not merge until
Expected result: it should show the expected LoginEmailViewController
Update release notes:
RELEASE-NOTES.txtif necessary.