Skip to content

Conversation

@mindgraffiti
Copy link
Contributor

@mindgraffiti mindgraffiti commented Mar 18, 2020

Ref. #2003.

In this PR

To Test

  1. Check out this branch
  2. rake dependencies
  3. Run unit tests
  4. Build and run
  5. Log out
  6. Select the "Log in with Jetpack" button.

Do not merge until

  1. The Authenticator PR has been merged: Remove segue .showLoginEmail wordpress-mobile/WordPressAuthenticator-iOS#207 ✔️
  2. A new Authenticator release has been created ✔️
  3. The release is published on Cocoapods trunk ✔️
  4. This PR points to the new release ✔️

Expected result: it should show the expected LoginEmailViewController

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

TIL that Cocoapods does not like our beta versions and will ignore newer beta versions.
@mindgraffiti mindgraffiti added the type: enhancement A request for an enhancement. label Mar 18, 2020
@mindgraffiti mindgraffiti added this to the 3.9 milestone Mar 18, 2020
@mindgraffiti mindgraffiti requested review from pmusolino and shiki March 18, 2020 15:32
@mindgraffiti mindgraffiti self-assigned this Mar 18, 2020
@mindgraffiti mindgraffiti changed the title Make the beta pods an explicit version and point to latest Auth changes [Auth] Remove the .showLoginEmail segue and navigate programmatically Mar 18, 2020
@shiki
Copy link
Contributor

shiki commented Mar 19, 2020

@mindgraffiti It looks like there are conflicts in Podfile and Podfile.lock. 🙂

@peril-woocommerce
Copy link

peril-woocommerce bot commented Mar 19, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@mindgraffiti
Copy link
Contributor Author

@shiki fixed 🙂

Copy link
Contributor

@shiki shiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mindgraffiti! I have a question about the pod versions.

Copy link
Contributor

@shiki shiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thuy! Thank you for reverting the Podfile change. And sorry for the delay!

:shipit:

@mindgraffiti
Copy link
Contributor Author

Thank you @shiki !

@mindgraffiti mindgraffiti merged commit ff772f3 into develop Mar 20, 2020
@mindgraffiti mindgraffiti deleted the issue/2003-remove-segue-showLoginEmail branch March 20, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A request for an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants