Skip to content

Conversation

@mindgraffiti
Copy link
Contributor

@mindgraffiti mindgraffiti commented Mar 23, 2020

This PR removes the segue that sends a user to the "Magic Link sent" screen and updates the programmatic navigation for opening the app after a Magic Link has been clicked.

See also: wordpress-mobile/WordPressAuthenticator-iOS#217

To test:

  1. Check out this branch
  2. rake dependencies
  3. Build and run
  4. Navigate through the Login flow (listed below)

Login Flow

  1. Select the Log in with Jetpack button
  2. Enter a valid email address that can use Magic Links, select the Next button
  3. Select the Send Link button
  4. Verify you are navigated to the "Magic link sent" screen
  5. Verify you received an emailed magic link
  6. Open the magic link
  7. Verify the magic link navigates you to the "Continue" screen

Do not merge until:

  1. The Authenticator PR has been merged: Remove segue .showLinkMailView wordpress-mobile/WordPressAuthenticator-iOS#217 ✔️
  2. A new Authenticator release has been created ✔️
  3. The release is published on Cocoapods trunk ✔️
  4. This PR points to the new release ✔️

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mindgraffiti mindgraffiti added type: enhancement A request for an enhancement. feature: login Related to any part of the log in or sign in flow, or authentication. labels Mar 23, 2020
@mindgraffiti mindgraffiti added this to the 4.0 milestone Mar 23, 2020
@mindgraffiti mindgraffiti self-assigned this Mar 23, 2020
@peril-woocommerce
Copy link

peril-woocommerce bot commented Mar 23, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Login with magic link worked nicely 👍

Copy link
Contributor

@pmusolino pmusolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Thanks @mindgraffiti!

@mindgraffiti
Copy link
Contributor Author

Thank you for the reviews @jaclync and @pmusolino !

@mindgraffiti mindgraffiti merged commit ad4f875 into develop Mar 24, 2020
@mindgraffiti mindgraffiti deleted the issue/2003-remove-segue-showLinkMailView branch March 24, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: login Related to any part of the log in or sign in flow, or authentication. type: enhancement A request for an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants