Skip to content

Conversation

@jleandroperez
Copy link
Contributor

Details:

In this PR we're dropping a callback parameter which is not currently used by the WordPressAuthenticator. No new feature is being introduced.

To test:

  1. Verify the branch builds correctly
  2. Perform a fresh install, and verify the Login flow works as expected.

NOTE: Once this PR is approved, we'll swap to a formal WordPressAuthenticator release in the podfile.

cc @bummytime @mindgraffiti
(Thanks in advance!!!)

@jleandroperez jleandroperez added the type: task An internally driven task. label Jul 11, 2018
@jleandroperez jleandroperez added this to the External closed beta milestone Jul 11, 2018
@jleandroperez jleandroperez self-assigned this Jul 11, 2018
Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

@jleandroperez jleandroperez merged commit 8ed3a61 into develop Jul 12, 2018
@jleandroperez jleandroperez deleted the issue/updating-authenticator-api branch July 12, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants