Skip to content

WordPressAuthenticator: Wiring the latest Delegate's API #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 12, 2018
Merged

WordPressAuthenticator: Wiring the latest Delegate's API #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae37b4e
Podfile: Updating WordPressAuthenticator's reference
jleandroperez Jul 11, 2018
94ae62a
AuthenticationManager: Wiring the new WordPressAuthenticatorDelegate API
jleandroperez Jul 11, 2018
12f084b
Podfile: Updating WordPressAuthenticator to Mark 1.0.2
jleandroperez Jul 12, 2018
9cd6745
Updating Authenticator to Mark 1.0.2
jleandroperez Jul 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ target 'WooCommerce' do
#
pod 'Automattic-Tracks-iOS', :git => 'https://github.com/Automattic/Automattic-Tracks-iOS.git', :tag => '0.2.3'
pod 'Gridicons', '0.15'
pod 'WordPressAuthenticator', '~> 1.0'
pod 'WordPressAuthenticator', '1.0.2'


# External Libraries
Expand Down
8 changes: 4 additions & 4 deletions Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ PODS:
- Reachability (3.2)
- SVProgressHUD (2.2.5)
- UIDeviceIdentifier (0.5.0)
- WordPressAuthenticator (1.0.1):
- WordPressAuthenticator (1.0.2):
- 1PasswordExtension (= 1.8.5)
- Alamofire (= 4.7.2)
- CocoaLumberjack (= 3.4.2)
Expand Down Expand Up @@ -72,7 +72,7 @@ DEPENDENCIES:
- Crashlytics (~> 3.10)
- Gridicons (= 0.15)
- KeychainAccess (~> 3.1)
- WordPressAuthenticator (~> 1.0)
- WordPressAuthenticator (= 1.0.2)

SPEC REPOS:
https://github.com/cocoapods/specs.git:
Expand Down Expand Up @@ -126,12 +126,12 @@ SPEC CHECKSUMS:
Reachability: 33e18b67625424e47b6cde6d202dce689ad7af96
SVProgressHUD: 1428aafac632c1f86f62aa4243ec12008d7a51d6
UIDeviceIdentifier: a959a6d4f51036b4180dd31fb26483a820f1cc46
WordPressAuthenticator: 60c07bcfb6f1578afaf17621ae4393d688c2ede9
WordPressAuthenticator: 20e8eb9cb61bef82370658037bdf9ca24a54570a
WordPressKit: a24baaa783c3a221f2d9a51c19318cbb27333373
WordPressShared: 063e1e8b1a7aaf635abf17f091a2d235a068abdc
WordPressUI: af141587ec444f9af753a00605bd0d3f14d8d8a3
wpxmlrpc: bfc572f62ce7ee897f6f38b098d2ba08732ecef4

PODFILE CHECKSUM: 60104ed4eaf82cee487f83818dceb80f392ce97f
PODFILE CHECKSUM: cf5b7216652672de11a865ab3265c7b0c38117e2

COCOAPODS: 1.5.3
9 changes: 7 additions & 2 deletions WooCommerce/Classes/Authentication/AuthenticationManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,14 +167,19 @@ extension AuthenticationManager: WordPressAuthenticatorDelegate {

/// Synchronizes the specified WordPress Account.
///
func sync(credentials: WordPressCredentials, onCompletion: @escaping (Error?) -> Void) {
func sync(credentials: WordPressCredentials, onCompletion: @escaping () -> Void) {
guard case let .wpcom(username, authToken, _, _) = credentials else {
fatalError("Self Hosted sites are not supported. Please review the Authenticator settings!")
}

// TODO: This is *temporary*. Already gone in a branch!!
let onCompletionWrapper = { (_ error: Error?) in
onCompletion()
}

StoresManager.shared
.authenticate(credentials: .init(username: username, authToken: authToken))
.synchronizeEntities(onCompletion: onCompletion)
.synchronizeEntities(onCompletion: onCompletionWrapper)
}

/// Tracks a given Analytics Event.
Expand Down