Currency Mark1: SiteSettings Networking #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleandroperez
approved these changes
Oct 22, 2018
Contributor
jleandroperez
left a comment
jleandroperez
left a comment
There was a problem hiding this comment.
✅ Code looks great!!
✅ Unit tests are happy
✅ Everything makes sense!!
Neat PR, as usual!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Networking framework logic for site settings. We are making a single network call to retrieve all settings in the
generalgroup.Partially addresses #312
Testing
@jleandroperez can you give this a quick 👀 ? Thanks!