Currency Mark2: SiteSettings Storage + Yosemite #377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off of #369 and adds the Storage + Yosemite framework logic for site settings. Stuff added here:
SiteSettingentityloadSiteSettings()andloadSiteSetting()toStorageType+ExtensionsStorageSiteSettingsandSiteSettingtypealiasesReadOnlyTypeandReadOnlyConvertibleextensions forSiteSettingSettingStorestoreSettingAction.retrieveSiteSettings()actionSettingStoreTestsNote: This code is not wired up to the main app yet — next PR will have that. 😄
Partially addresses #312
Testing
@jleandroperez Could you take a 👀 at this PR? Thanks!!! 🙇
(It's a large PR again because of the test
JSON... sorry!)