Skip to content

Conversation

@jleandroperez
Copy link
Contributor

Scenario: Corrupt HTML

  1. Type Heading
  2. Select the new word and toggle H1
  3. Press return
  4. Type a two characters
  5. Delete one of the two characters

Verify that the HTML generated looks as follows:
<h1>Heading<br></h1>A

Scenario: Randomness

  1. Launch the empty editor
  2. Toggle H1
  3. Enter some text. Hit return
  4. Enter some text

Verify that the second line is, effectively, in Paragraph style

Nukes Zero Width Characters Usage in HeaderFormatter (Ref. #414)
Closes #407
Closes #415

Needs Review: @diegoreymendez
cc @SergioEstevao

Thanks in advance gentlemen!
:bowtie:

Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pure gold. Nice work @jleandroperez !

@jleandroperez
Copy link
Contributor Author

Woooo thanks Diego!!!

@jleandroperez jleandroperez merged commit 3c4a20d into develop Apr 12, 2017
@jleandroperez jleandroperez deleted the issue/407-header-style-html-corruption branch April 12, 2017 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants