Skip to content

[Bloganuary] Create Bloganuary Nudge FF - #19664

Merged
thomashorta merged 2 commits into
feature/bloganuary-nudgefrom
issue/19663-bloganuary-nudge-ff
Nov 27, 2023
Merged

[Bloganuary] Create Bloganuary Nudge FF#19664
thomashorta merged 2 commits into
feature/bloganuary-nudgefrom
issue/19663-bloganuary-nudge-ff

Conversation

@thomashorta

Copy link
Copy Markdown
Contributor

Part of #19663


To Test:

Not much to test so far (just created the FF but not being used), only check if the appropriate flag exists in the debug menu: bloganuary_dashboard_nudge and it's defaulted to OFF.


Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot

wpmobilebot commented Nov 23, 2023

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19664-1836b2b
Commit1836b2b
Direct Downloadjetpack-prototype-build-pr19664-1836b2b.apk
Note: Google Login is not supported on these builds.

@wpmobilebot

wpmobilebot commented Nov 23, 2023

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19664-1836b2b
Commit1836b2b
Direct Downloadwordpress-prototype-build-pr19664-1836b2b.apk
Note: Google Login is not supported on these builds.

@RenanLukas RenanLukas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM :shipit:

I've left a question but if it doesn't make sense feel free to merge it


private const val BLOGANUARY_NUDGE_REMOTE_FIELD = "bloganuary_dashboard_nudge"

@Feature(BLOGANUARY_NUDGE_REMOTE_FIELD, false)

@RenanLukas RenanLukas Nov 27, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Would it make sense to have the default value as true in case this is being merged directly in the new version's branch?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the FF should default to true only after all Bloganuary changes are merged, to avoid a state where we have partial changes with the flag ON.

But now that you mentioned it, since we will need to target the beta release branch directly, it might make more sense to target a feature branch, and have this flag ON, so we can then only merge 1 PR to the release branch and avoid any incomplete code or multiple PRs targeting release. I will target feature/bloganuary-nudge and default this FF to ON.

@thomashorta
thomashorta force-pushed the issue/19663-bloganuary-nudge-ff branch from 04d260f to 2a901c8 Compare November 27, 2023 14:50
@peril-wordpress-mobile

Copy link
Copy Markdown
Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@thomashorta
thomashorta changed the base branch from trunk to feature/bloganuary-nudge November 27, 2023 14:53
@wpmobilebot

Copy link
Copy Markdown
Contributor
2 Warnings
⚠️ Class BloganuaryNudgeFeatureConfig is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ This PR is assigned to the milestone 23.8. The due date for this milestone has already passed.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@spencertransier spencertransier modified the milestones: 23.8, 23.9 Nov 27, 2023
@thomashorta
thomashorta merged commit 12793d5 into feature/bloganuary-nudge Nov 27, 2023
@thomashorta
thomashorta deleted the issue/19663-bloganuary-nudge-ff branch November 27, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants