[Bloganuary] Create Bloganuary Nudge FF - #19664
Conversation
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19664-1836b2b | |
| Commit | 1836b2b | |
| Direct Download | jetpack-prototype-build-pr19664-1836b2b.apk |
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19664-1836b2b | |
| Commit | 1836b2b | |
| Direct Download | wordpress-prototype-build-pr19664-1836b2b.apk |
RenanLukas
left a comment
There was a problem hiding this comment.
Thanks for the PR, LGTM ![]()
I've left a question but if it doesn't make sense feel free to merge it
|
|
||
| private const val BLOGANUARY_NUDGE_REMOTE_FIELD = "bloganuary_dashboard_nudge" | ||
|
|
||
| @Feature(BLOGANUARY_NUDGE_REMOTE_FIELD, false) |
There was a problem hiding this comment.
💡 Would it make sense to have the default value as true in case this is being merged directly in the new version's branch?
There was a problem hiding this comment.
Ideally the FF should default to true only after all Bloganuary changes are merged, to avoid a state where we have partial changes with the flag ON.
But now that you mentioned it, since we will need to target the beta release branch directly, it might make more sense to target a feature branch, and have this flag ON, so we can then only merge 1 PR to the release branch and avoid any incomplete code or multiple PRs targeting release. I will target feature/bloganuary-nudge and default this FF to ON.
04d260f to
2a901c8
Compare
Generated by 🚫 dangerJS |
Generated by 🚫 Danger |


Part of #19663
To Test:
Not much to test so far (just created the FF but not being used), only check if the appropriate flag exists in the debug menu:
bloganuary_dashboard_nudgeand it's defaulted to OFF.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.