Skip to content

[Bloganuary] Implement Dashboard Nudge card hide button functionality - #19677

Merged
thomashorta merged 3 commits into
feature/bloganuary-nudgefrom
issue/19663-bloganuary-card-hide-button
Nov 28, 2023
Merged

[Bloganuary] Implement Dashboard Nudge card hide button functionality#19677
thomashorta merged 3 commits into
feature/bloganuary-nudgefrom
issue/19663-bloganuary-card-hide-button

Conversation

@thomashorta

Copy link
Copy Markdown
Contributor

Part of #19663

Implement the "Hide this" button functionality for hiding the Bloganuary Nudge card from the dashboard.

19663-bloganuary-card-hide-button.mp4

To Test:

  1. Install and log into the Jetpack app (with a site that has blogging prompts available)
  2. Make sure the bloganuary_dashboard_nudge FF is active in Debug Settings
  3. Go to My Site dashboard
  4. Verify the Bloganuary card is showing
  5. Tap the context menu (three-dots)
  6. Tap "Hide this"
  7. Verify the Bloganuary card is hidden for this site
  8. Select a different site that also has blogging prompts available
  9. Verify the Bloganuary card is still shown for the other site

The only way to reset this "hidden" state is to clear the app settings / reinstall the app.


Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • Updated Bloganuary unit tests.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Nov 27, 2023

Copy link
Copy Markdown
Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@thomashorta
thomashorta changed the base branch from trunk to issue/19663-bloganuary-nudge-dashboard-card November 27, 2023 22:51
@wpmobilebot

wpmobilebot commented Nov 27, 2023

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19677-01a44ad
Commit01a44ad
Direct Downloadjetpack-prototype-build-pr19677-01a44ad.apk
Note: Google Login is not supported on these builds.

@wpmobilebot

wpmobilebot commented Nov 27, 2023

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19677-01a44ad
Commit01a44ad
Direct Downloadwordpress-prototype-build-pr19677-01a44ad.apk
Note: Google Login is not supported on these builds.

@osullivanchris osullivanchris left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I assume this does not show up in personalisation once switched off.

@thomashorta

Copy link
Copy Markdown
Contributor Author

Looks good. I assume this does not show up in personalisation once switched off.

@osullivanchris yep, like some other info cards (e.g.: domain transfer) this does not show up in the personalization settings, so when it's hidden it's gone.

@RenanLukas RenanLukas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It's working as expected and code LGTM.

@thomashorta
thomashorta force-pushed the issue/19663-bloganuary-card-hide-button branch from 2aae378 to 01a44ad Compare November 28, 2023 15:50
@wpmobilebot

Copy link
Copy Markdown
Contributor
1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Base automatically changed from issue/19663-bloganuary-nudge-dashboard-card to feature/bloganuary-nudge November 28, 2023 18:48
@thomashorta
thomashorta merged commit 41d6df0 into feature/bloganuary-nudge Nov 28, 2023
@thomashorta
thomashorta deleted the issue/19663-bloganuary-card-hide-button branch November 28, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants