[Bloganuary] Implement Dashboard Nudge card hide button functionality - #19677
Merged
thomashorta merged 3 commits intoNov 28, 2023
Merged
Conversation
Generated by 🚫 dangerJS |
thomashorta
changed the base branch from
trunk
to
issue/19663-bloganuary-nudge-dashboard-card
November 27, 2023 22:51
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19677-01a44ad | |
| Commit | 01a44ad | |
| Direct Download | jetpack-prototype-build-pr19677-01a44ad.apk |
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19677-01a44ad | |
| Commit | 01a44ad | |
| Direct Download | wordpress-prototype-build-pr19677-01a44ad.apk |
osullivanchris
approved these changes
Nov 28, 2023
osullivanchris
left a comment
There was a problem hiding this comment.
Looks good. I assume this does not show up in personalisation once switched off.
Contributor
Author
@osullivanchris yep, like some other info cards (e.g.: domain transfer) this does not show up in the personalization settings, so when it's hidden it's gone. |
RenanLukas
approved these changes
Nov 28, 2023
RenanLukas
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. It's working as expected and code LGTM.
thomashorta
force-pushed
the
issue/19663-bloganuary-card-hide-button
branch
from
November 28, 2023 15:50
2aae378 to
01a44ad
Compare
Contributor
Generated by 🚫 Danger |
Base automatically changed from
issue/19663-bloganuary-nudge-dashboard-card
to
feature/bloganuary-nudge
November 28, 2023 18:48
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Part of #19663
Implement the "Hide this" button functionality for hiding the Bloganuary Nudge card from the dashboard.
19663-bloganuary-card-hide-button.mp4
To Test:
bloganuary_dashboard_nudgeFF is active in Debug SettingsThe only way to reset this "hidden" state is to clear the app settings / reinstall the app.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.UI Changes Testing Checklist: