-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add :libs:processors unit tests
#20213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4775ece to
cf2a4cc
Compare
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20213-ec1baba | |
| Commit | ec1baba | |
| Direct Download | jetpack-prototype-build-pr20213-ec1baba.apk |
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20213-ec1baba | |
| Commit | ec1baba | |
| Direct Download | wordpress-prototype-build-pr20213-ec1baba.apk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #20213 +/- ##
==========================================
+ Coverage 40.18% 40.31% +0.13%
==========================================
Files 1469 1469
Lines 67672 67672
Branches 11211 11211
==========================================
+ Hits 27193 27281 +88
+ Misses 37985 37897 -88
Partials 2494 2494 ☔ View full report in Codecov by Sentry. |
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this @wzieba 🙇
The code changes look consistent to me and the added tests make sense. I also didn't notice any side effects in the code generation 🎉


Description
This PR adds tests to kotlin poet's code generators used in
:libs:processorsmodule.Initially, I also wanted to introduce tests for code generation itself, performed in
RemoteConfigProcessor, using kotlin-compile-testing. Unfortunately, we have a cycle dependency::libs:processorsmodule doesn't have access toorg.wordpress.android.util.config.AppConfigclass, but uses it during code generation inRemoteFeatureConfigCheckBuilder, making it impossible to test.Additionally, this PR updates kotlin poet version to the newest stable and addresses breaking changes.
To Test:
Unit test should be just fine.
Regression Notes
Potential unintended areas of impact
RemoteFeatureConfigCheckFeaturesInDevelopmentRemoteFeatureConfigDefaultsRemoteFieldConfigDefaultsWhat I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist: