-
Notifications
You must be signed in to change notification settings - Fork 1.3k
:libs:processors annotation processing unit test
#20227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20227-305cf90 | |
| Commit | 305cf90 | |
| Direct Download | jetpack-prototype-build-pr20227-305cf90.apk |
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20227-305cf90 | |
| Commit | 305cf90 | |
| Direct Download | wordpress-prototype-build-pr20227-305cf90.apk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #20227 +/- ##
==========================================
+ Coverage 40.32% 40.37% +0.05%
==========================================
Files 1469 1469
Lines 67687 67687
Branches 11211 11211
==========================================
+ Hits 27292 27326 +34
+ Misses 37901 37861 -40
- Partials 2494 2500 +6 ☔ View full report in Codecov by Sentry. |
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the extra tests @wzieba 🙇
Fortunately, I was able to overcome this by providing a fake AppConfig class to sources of test compilation.
Awesome 🏅
The tests LGTM 🎉


Description
This PR adds a unit test for
RemoteConfigProcessor. It'll be useful to validate the correctness ofkspmigration.Context
In #20213 I hesitate with adding unit test for main processing logic,
RemoteConfigProcessorclass, due to the cyclic dependency onAppConfigclass.Fortunately, I was able to overcome this by providing a fake
AppConfigclass to sources of test compilation.To Test
Not needed, CI check is fine.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist: