Skip to content

Conversation

@wzieba
Copy link
Contributor

@wzieba wzieba commented Feb 21, 2024

Description

This PR adds a unit test for RemoteConfigProcessor. It'll be useful to validate the correctness of ksp migration.

Context

In #20213 I hesitate with adding unit test for main processing logic, RemoteConfigProcessor class, due to the cyclic dependency on AppConfig class.

Fortunately, I was able to overcome this by providing a fake AppConfig class to sources of test compilation.

To Test

Not needed, CI check is fine.


Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Unit
  3. What automated tests I added (or what prevented me from doing so)

    • Unit

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wzieba wzieba added this to the 24.4 milestone Feb 21, 2024
@wzieba wzieba requested a review from antonis February 21, 2024 17:35
@wzieba
Copy link
Contributor Author

wzieba commented Feb 21, 2024

hi @antonis 👋 as you reviewed #20213 , would you mind checking this PR as well? 🙂

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20227-305cf90
Commit305cf90
Direct Downloadjetpack-prototype-build-pr20227-305cf90.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20227-305cf90
Commit305cf90
Direct Downloadwordpress-prototype-build-pr20227-305cf90.apk
Note: Google Login is not supported on these builds.

@codecov
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72e7db7) 40.32% compared to head (305cf90) 40.37%.
Report is 2 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #20227      +/-   ##
==========================================
+ Coverage   40.32%   40.37%   +0.05%     
==========================================
  Files        1469     1469              
  Lines       67687    67687              
  Branches    11211    11211              
==========================================
+ Hits        27292    27326      +34     
+ Misses      37901    37861      -40     
- Partials     2494     2500       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the extra tests @wzieba 🙇

Fortunately, I was able to overcome this by providing a fake AppConfig class to sources of test compilation.

Awesome 🏅
The tests LGTM 🎉

@antonis antonis merged commit efb739f into trunk Feb 22, 2024
@antonis antonis deleted the kapt_processing_tests branch February 22, 2024 07:49
@wzieba wzieba mentioned this pull request Feb 22, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants