My Site Dashboard: Failing to load posts error not shown

[hassaanelgarem]

Expected behavior

Error message to be displayed inside posts cards when loading posts fails

Actual behavior

Next post view is displayed instead

Steps to reproduce the behavior

1. Replace the body of PostService.syncPostsOfType at PostService.m line 197 with:

double delayInSeconds = 1;
dispatch_time_t time = dispatch_time(DISPATCH_TIME_NOW, (int64_t)(delayInSeconds * NSEC_PER_SEC));    dispatch_after(time, dispatch_get_main_queue(), ^{
    NSError *error = [NSError errorWithDomain:@"" code:1 userInfo:nil];
    failure(error)
});

This simulates posts loading failure.

2. Do a fresh install to clear cached posts data
3. Open a site that has drafts and scheduled posts
4. Open the dashboard
5. Observe that the next post view is displayed instead of the error message