My Site Dashboard: Refactor dashboard architecture and data source - #18405
Merged
Conversation
Instead of `DashboardItem` which is harder to deal with
This reverts commit 8bc09ba.
…h-refactor/reduce-sections My Site Dashboard: Reduce usage of sections in the dashboard
…h-refactor/snapshot-logic My Site Dashboard: Refactor dashboard's data source
…h-refactor/snapshot-logic-tests My Site Dashboard: Dashboard data source unit tests
This is to avoid unneeded reload of the dashboard cards
This reverts commit 0653970.
Instead of syncing the first 3 of both
…h-refactor/sync-issue My Site Dashboard: Sync posts more often and reload cards less
hassaanelgarem
changed the title
Contributor
You can test the changes in Jetpack from this Pull Request by:
.ipa file can also be downloaded directly here.If you need access to App Center, please ask a maintainer to add you. |
Contributor
You can test the changes in WordPress from this Pull Request by:
.ipa file can also be downloaded directly here.If you need access to App Center, please ask a maintainer to add you. |
momo-ozawa
approved these changes
Apr 20, 2022
momo-ozawa
left a comment
momo-ozawa
left a comment
Contributor
There was a problem hiding this comment.
@hassaanelgarem Thank you for tackling this refactor!
| 19.8 | ||
| ----- | ||
|
|
||
| * [*] [internal] My Site Dashboard: Made some changes to the code architecture of the dashboard. The majority of the changes are related to the posts cards. It should have no visible changes but could cause regressions. [#18405] |
Contributor
There was a problem hiding this comment.
I think it worth mentioning: "please test it by creating drafts and scheduled posts and testing that they appear on the dashboard".
leandroalonso
approved these changes
Apr 20, 2022
Contributor
Author
|
@dvdchr FYI: This makes some changes to the dashboard's architecture. It shouldn't affect the blogging prompt card though. |
Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18355
Fixes #18208
Closes #18308
Description
This PR refactors how the dashboard displays the returned cards. Posts cards are significantly affected, as we now use a cell for each card instead of one cell for all cards.
The PR combines work done in the following PRs:
Testing Instructions
Testing isn't really needed as all changes have been tested in their corresponding PRs.
Regression Notes
Potential unintended areas of impact
Dashboard, especially posts cards
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual and unit tests, when applicable
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.