Skip to content

My Site Dashboard: Dashboard data source unit tests - #18311

Merged
hassaanelgarem merged 4 commits into
feature/dashboard-arch-refactor/basefrom
feature/dashboard-arch-refactor/snapshot-logic-tests
Apr 11, 2022
Merged

My Site Dashboard: Dashboard data source unit tests#18311
hassaanelgarem merged 4 commits into
feature/dashboard-arch-refactor/basefrom
feature/dashboard-arch-refactor/snapshot-logic-tests

Conversation

@hassaanelgarem

Copy link
Copy Markdown
Contributor

Part of #18308

Description

This adds and fixes tests related to #18309 and #18310

  • Fixes tests build errors in BlogDashboardServiceTests
  • Adds DashboardCardTests

Testing Instructions

N/A

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot

wpmobilebot commented Apr 7, 2022

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below
  • Then installing the build number pr18311-9cf84d1 from App Center on your iPhone

The .ipa file can also be downloaded directly here.
If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot

wpmobilebot commented Apr 7, 2022

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below
  • Then installing the build number pr18311-9cf84d1 from App Center on your iPhone

The .ipa file can also be downloaded directly here.
If you need access to App Center, please ask a maintainer to add you.

Base automatically changed from feature/dashboard-arch-refactor/snapshot-logic to feature/dashboard-arch-refactor/base April 11, 2022 12:17
@hassaanelgarem
hassaanelgarem merged commit 10a3800 into feature/dashboard-arch-refactor/base Apr 11, 2022
@hassaanelgarem
hassaanelgarem deleted the feature/dashboard-arch-refactor/snapshot-logic-tests branch April 11, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Unit and UI Tests and Tooling [Type] Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants