This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Merge Release 1.10.5 into master #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve button in `LoginEmailViewController` (#164) * Add `UIButton` extension to apply default styles to a plain text button. * Configure alternative label in `viewWillAppear` in `LoginEmailViewController`. * Bump pod version. * Move text button style configuration from `UIButton` extension to `WPStyleGuide+Login`. Update existing usage and configure the "Enter your password instead." text button in `LoginLinkRequestViewController`.
…n2FAViewController` (#165) * Style `sendCodeButton` in `viewWillAppear` in `Login2FAViewController`. * Bump pod version.
Set Ruby version to 2.5.5
VoiceOver auto-selects the first element in the view hierarchy. Unfortunately, the dismiss button is the first in the hierarchy since it needs to cover everything outside of the buttons view. This changes the `accessibilityElements` order so VoiceOver will prioritize the buttons view.
…ancements [VoiceOver] Login and Signup enhancements
Rather than using int as the type, we use DDLogLevel per https://github.com/CocoaLumberjack/CocoaLumberjack/blob/master/Documentation/DynamicLogLevels.md.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Release 1.10.5 into master