-
Notifications
You must be signed in to change notification settings - Fork 11
Remove segue .showLoginEmail #207
Conversation
Instead of "emailEntry"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mindgraffiti .
The signup to login flow is a bit different than develop. (Sign up for WordPress.com > Sign up with Email > Enter an email address that has an existing WP.com account)
developauto-populates the previously entered email address (thus auto-enabling theNextbutton).developdoes not show thesite addresslink. And I don't see that this has changed in the Unified design.
| develop | branch |
|---|---|
![]() |
![]() |
|
Thanks @ScoutHarris! I forgot to remove the segue from the signup storyboard that navigated to the EmailLoginViewController 🤦♀. Review this commit: 01725ec and try to build and run. It should be good to go! |
ScoutHarris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
![]()
|
Sorry I didn't get to review this. From my end, feel free to move ahead since @ScoutHarris already reviewed. |
|
Thanks @ScoutHarris ! |


Fixes #205
Ref. #182
This PR removes all references to the segue
.showEmailLoginand programmatically navigates the user to theLoginEmailViewController. There are 3 areas where the segues have been removed:To Test - WPiOS
bundle exec pod installand ensure there are no errorsTo Test - WCiOS
bundle exec pod install.showLoginEmailsegue and navigate programmatically woocommerce/woocommerce-ios#2007