Skip to content

Conversation

@mindgraffiti
Copy link
Contributor

Issue

I went to merge wordpress-mobile/WordPressAuthenticator-iOS#207 and #2007. Unfortunately, the Authenticator recently had a Gridicons pod update to 1.0-beta.1. Since the Gridicon pods can't be out of sync for version numbers in Authenticator podfile and in the main project's podfile, this PR must be approved before I can merge in #2007.

In this PR

  • updates the Authenticator to point to the latest pod changes, which upgraded Gridicons from 0.20 -> 1.0
  • updates the main podfile to Gridicons 1.0
  • find / replace deprecated Gridicons method calls

To Test

  1. rake dependencies
  2. Build and run
  3. Choose an icon at random from the code to smoke-test

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mindgraffiti mindgraffiti added the type: enhancement A request for an enhancement. label Mar 19, 2020
@mindgraffiti mindgraffiti added this to the 3.9 milestone Mar 19, 2020
@mindgraffiti mindgraffiti self-assigned this Mar 19, 2020
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Code: ✅
Testing: ✅

example screenshots:

order details order notes
Simulator Screen Shot - iPhone 11 - 2020-03-20 at 15 50 19 Simulator Screen Shot - iPhone 11 - 2020-03-20 at 15 50 30

@mindgraffiti
Copy link
Contributor Author

Thanks @jaclync !

@mindgraffiti mindgraffiti merged commit bb90ed2 into develop Mar 20, 2020
@mindgraffiti mindgraffiti deleted the issue/update-gridicons-pod branch March 20, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A request for an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants