Skip to content

Conversation

@AkshayWarrier
Copy link
Contributor

Closes #289

@sonnyp sonnyp assigned sonnyp and unassigned sonnyp Jun 4, 2023
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increase the spacing between Split Button and Button Content
It looks like a single block.

This is a great example but it's a bit off, there shouldn't be a margin around the border.
Screenshot from 2023-06-05 13-17-37

Icon buttons shouldn't so wide
image

@AkshayWarrier AkshayWarrier requested a review from sonnyp June 5, 2023 12:50
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Made a couple of minor changes with Tobias a7b579b

@sonnyp sonnyp merged commit 43949af into main Jun 10, 2023
@sonnyp sonnyp deleted the akshaywarrier/advancedbuttons branch June 10, 2023 13:14
sonnyp pushed a commit to SoNiC-HeRE/Workbench that referenced this pull request Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Advanced Button library entry

6 participants