library: Add Boxed lists entry #210
Conversation
|
How is it going? Don't hesitate to let us know in the chatroom if you have any question. |
Sorry that it takes so long I almost forgot about this pr. I'll try to complete it soon. I've got few minor issues, I'll ask it on the chat later |
krlade
force-pushed
the
row-demo
branch
2 times, most recently
from
449a5f4 to
3019a2d
Compare
|
It should be ready for initial review |
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
Good start.
Please add 18px margin between the sections
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
There are quite a lot more type of rows but it would be too big in this one entry.
Let's get this in and see how we can extend/improvate later 👍
sonnyp
force-pushed
the
main
branch
3 times, most recently
from
05f69f1 to
55e450f
Compare
|
hey @karl0d, do you want to finish this? If so, make sure to add your name to the list of contributors in |
|
Yes I want to finish it, it's almost ready. I will push my changes soon |
|
Should this demo cover new widgets introduced in libadwaita 1.4 such as Adw.SpinRow and Adw.SwitchRow? If not so, there is only one issue blocking this pr from being ready |
|
Sorry for the late answer, I missed the notification somehow.
No, it's not available in Workbench. When GNOME 45 releases (with libadwaita 1.4) we will make a list of new things we want to demo in Workbench. |
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
Thanks!
Please avoid force pushing, it makes it hard to review, specially after some time coming back to this.
I made a few changns https://github.com/sonnyp/Workbench/pull/210/files
- The ListBox should be the parent of rows
selection-mode: none;andstyles ["boxed-list"]was missing on ListBox as documented by libadwaita- Since we now have a "Preferences Window" demo, I removed all Preferences related widgets
5 participants
This pull request is still work in progress. I'm opening this to indicate that some work is being done and to avoid duplicating efforts.
The goal of this pr is to create a demo for a boxed list, mainly focuses on AdwPreferencesGroup, AdwActionRow, AdwComboRow and AdwEntryRow with an example use cases.
Related to workbenchdev/demos#3