Skip to content

Bug/#1437 comment database id throws errors#1551

Merged
jasonbahl merged 2 commits into
wp-graphql:developfrom
jasonbahl:bug/#1437-comment-databaseId-throws-errors
Nov 6, 2020
Merged

Bug/#1437 comment database id throws errors#1551
jasonbahl merged 2 commits into
wp-graphql:developfrom
jasonbahl:bug/#1437-comment-databaseId-throws-errors

Conversation

@jasonbahl

Copy link
Copy Markdown
Collaborator

closes #1437

Before

Screen Shot 2020-11-06 at 10 37 13 AM

After
Screen Shot 2020-11-06 at 10 36 53 AM

@jasonbahl jasonbahl added type: bug Issue that causes incorrect or unexpected behavior object type: comment Relating to the Comment Type component: query Relating to GraphQL Queries labels Nov 6, 2020
@jasonbahl jasonbahl added this to the 1.0 release milestone Nov 6, 2020
@jasonbahl jasonbahl self-assigned this Nov 6, 2020
@codecov

codecov Bot commented Nov 6, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1551 into develop will increase coverage by 18.59%.
The diff coverage is 53.06%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #1551       +/-   ##
============================================
+ Coverage    59.24%   77.84%   +18.59%     
============================================
  Files          193      193               
  Lines        11402     9302     -2100     
============================================
+ Hits          6755     7241      +486     
+ Misses        4647     2061     -2586     
Impacted Files Coverage Δ
src/Admin/Settings/Settings.php 0.00% <0.00%> (ø)
src/Admin/Settings/SettingsRegistry.php 0.00% <0.00%> (ø)
src/Model/Comment.php 90.27% <ø> (+21.16%) ⬆️
src/Request.php 61.59% <50.00%> (+0.44%) ⬆️
src/Type/Object/Comment.php 94.11% <50.00%> (+44.11%) ⬆️
wp-graphql.php 33.52% <50.00%> (+1.67%) ⬆️
src/Router.php 30.09% <75.00%> (+0.97%) ⬆️
access-functions.php 66.38% <100.00%> (+3.42%) ⬆️
src/Data/Loader/CommentLoader.php 88.88% <100.00%> (+16.66%) ⬆️
src/Utils/DebugLog.php 90.90% <100.00%> (+15.90%) ⬆️
... and 178 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f801ab1...e69ab47. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: query Relating to GraphQL Queries object type: comment Relating to the Comment Type type: bug Issue that causes incorrect or unexpected behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Querying Comment.databaseId returns errors and "null" response

1 participant