delete model after creating - #1069
Merged
Merged
Conversation
Collaborator
|
Collaborator
|
Queue triage (2026-07-27)
GitHub is the status record; update this PR rather than the external spreadsheet. |
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
Contributor
Resolved. I merged |
ebhills
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integration tests for
train.classify,train.extract,train.lookup, andtrain.standardizecreate real models on the WrangleWorks platform but never clean them up, leaving a growing number of orphaned test models in the account. This adds awrangles.train.delete()method and updates the affected tests to delete the models they create.wrangles.train.delete(model_id), which calls theDELETE /model/deleteAPI endpoint and raisesRuntimeErroron a non-OK response.try/finallyso the created model is deleted after the test runs, regardless of pass/fail._delete_model_from_log()helper totests/connectors/test_train.pyto extract a model ID from a logged message (e.g."New classify model created :: <id>") and delete it, tolerating failure while cleaning up.TestTrainDeletetest class covering create-then-delete for classify, extract, lookup, and standardize models, plus a test that a non-OK delete response raisesRuntimeError.