add train.delete to delete a model by model_id - #997
Merged
Conversation
2 tasks
thomasstvr
requested changes
Jun 9, 2026
thomasstvr
left a comment
thomasstvr
left a comment
Collaborator
There was a problem hiding this comment.
We are going to need more tests, at least one for each type of wrangle the train connector can create. At the same time, (if I remember correctly) there aren't very many tests that train new models. Can you make sure each train connector is properly tested for creating a new model and add this delete to each one? That would take care of both cases with one test.
Co-Authored-By: Mariia Borodii <mborodii@binariks.com>
mborodii-prog
force-pushed
the
991-enhancement-delete_wrangle-wrangle
branch
from
June 30, 2026 19:42
fa905f1 to
6cbcc51
Compare
The delete endpoint is /model/content (consistent with all other model operations), not /model/delete. Tests now mock the HTTP delete call since the backend endpoint is gated on API-Core PR #111. Co-Authored-By: Mariia Borodii <mborodii@binariks.com>
mborodii-prog
marked this pull request as ready for review
June 30, 2026 20:20
2 tasks
ebhills
marked this pull request as draft
July 27, 2026 14:03
Collaborator
|
Queue triage (2026-07-27)
GitHub is the status record; update this PR rather than the external spreadsheet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Must be merged after API-Core changes https://github.com/wrangleworks/API-Core/pull/111
Summary
wrangles.train.delete(model_id)as a static method on thetrainclass inwrangles/train.pymodel_id— no wrangle type requiredRuntimeErrorif the API returns a non-OK responserecipe_wrangles/main.py, so it is never auto-discovered as a recipe wrangle or bound as a DataFrame accessor