feat: Add Japanese and Korean localization#72
Merged
wxtsky merged 2 commits intowxtsky:mainfrom Apr 16, 2026
Merged
Conversation
Owner
|
翻译质量不错,测试覆盖也很全面 👍 提几个需要注意的点: 1. 与其他 PR 的 L10n key 冲突以下已合并或待合并的 PR 新增了 L10n key,合并后需要补上日韩翻译:
建议 rebase 到最新 main 后,用你已有的 2.
|
e7574c2 to
06902dd
Compare
wxtsky
added a commit
that referenced
this pull request
Apr 16, 2026
- Add approval_queue_label / approval_details_expand / approval_details_collapse for ja and ko so the key-parity tests pass after #72 was merged on top of #98 - Update about_desc2 from 10 to 11 across all five languages to reflect the TraeCli addition in #98 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ja) and Korean (ko) localization support alongside the existing English, Chinese, and Turkish optionsWhy
The app already had a lightweight in-file localization path for Turkish. This extends the same mechanism so Japanese and Korean users can select those languages manually or have them picked up automatically from system locale settings.
User Impact
Users can now choose
日本語or한국어in Settings, andsystemlanguage mode will resolve tojaorkowhen the system preferred language matches.Validation
swift test --filter L10nTests