Skip to content

feat: Add Japanese and Korean localization#72

Merged
wxtsky merged 2 commits intowxtsky:mainfrom
alvis-HaoH:codex/add-ja-ko-localization
Apr 16, 2026
Merged

feat: Add Japanese and Korean localization#72
wxtsky merged 2 commits intowxtsky:mainfrom
alvis-HaoH:codex/add-ja-ko-localization

Conversation

@alvis-HaoH
Copy link
Copy Markdown
Contributor

Summary

  • add Japanese (ja) and Korean (ko) localization support alongside the existing English, Chinese, and Turkish options
  • detect Japanese and Korean system locales when the app language is set to follow the system
  • extend localization tests to cover key completeness, representative strings, and placeholder formatting for both new languages

Why

The app already had a lightweight in-file localization path for Turkish. This extends the same mechanism so Japanese and Korean users can select those languages manually or have them picked up automatically from system locale settings.

User Impact

Users can now choose 日本語 or 한국어 in Settings, and system language mode will resolve to ja or ko when the system preferred language matches.

Validation

  • swift test --filter L10nTests

@alvis-HaoH alvis-HaoH changed the title [codex] Add Japanese and Korean localization feat: Add Japanese and Korean localization Apr 12, 2026
@wxtsky
Copy link
Copy Markdown
Owner

wxtsky commented Apr 15, 2026

翻译质量不错,测试覆盖也很全面 👍

提几个需要注意的点:

1. 与其他 PR 的 L10n key 冲突

以下已合并或待合并的 PR 新增了 L10n key,合并后需要补上日韩翻译:

建议 rebase 到最新 main 后,用你已有的 L10nTests 跑一下,缺失的 key 会自动报出来。

2. about_desc2 工具数量硬编码

日韩翻译里写的是 "8 種 CLI/IDE",但目前支持的工具已经是 10 个了(刚合了 Kimi CLI)。请更新为实际数量。

3. 准备好后随时标记 Ready for Review

核心翻译部分没有问题,解决上面的冲突后可以直接出 Draft。

@alvis-HaoH alvis-HaoH force-pushed the codex/add-ja-ko-localization branch from e7574c2 to 06902dd Compare April 16, 2026 16:23
@alvis-HaoH alvis-HaoH marked this pull request as ready for review April 16, 2026 16:23
@wxtsky wxtsky merged commit 162febc into wxtsky:main Apr 16, 2026
wxtsky added a commit that referenced this pull request Apr 16, 2026
- Add approval_queue_label / approval_details_expand / approval_details_collapse
  for ja and ko so the key-parity tests pass after #72 was merged on top of #98
- Update about_desc2 from 10 to 11 across all five languages to reflect the
  TraeCli addition in #98

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants