feature: add configurable auto-collapse after session jump#86
Merged
wxtsky merged 1 commit intowxtsky:mainfrom Apr 15, 2026
Merged
feature: add configurable auto-collapse after session jump#86wxtsky merged 1 commit intowxtsky:mainfrom
wxtsky merged 1 commit intowxtsky:mainfrom
Conversation
Add a behavior toggle to auto-collapse the panel only after successful click jump validation, with failure shake/sound feedback and a dedicated click-jump preview animation aligned with mouse-leave sizing/timing.
nguyenvanduocit
pushed a commit
to nguyenvanduocit/CodeIsland
that referenced
this pull request
Apr 15, 2026
- PR wxtsky#80 MERGED: configurable notch height modes → T-026 - PR wxtsky#86 open: auto-collapse after session jump → T-027 (watch) - PR wxtsky#76 open: message input bar + TerminalWriter → T-028 (watch) - Issue wxtsky#84: Ghostty quick terminal activation bug → T-029 - Note PR wxtsky#69 and wxtsky#70 now merged upstream (T-024, T-025 ready) - vibe-island: no new code changes https://claude.ai/code/session_01Hoa4hooNsWEnv8vC42x8G3
wxtsky
approved these changes
Apr 15, 2026
Owner
wxtsky
left a comment
There was a problem hiding this comment.
LGTM! 功能完整,默认关闭不影响现有用户。
亮点:
evaluateJumpValidation设计好——依赖注入isCancelled/sleep/checkSucceeded,方便测试- 失败反馈体验好:错误音效 + 抖动动画
- 远程会话跳过自动收起(合理)
- 设置页预览动画完整,循环 seam smooth
- 测试覆盖全面:成功/失败/取消/动画时间线关键帧
小 nit(不阻塞):
jumpFailureShakeSequence()和shouldTriggerJumpFailureFeedback()是 module-level 而非 private,理解是为了测试可见性,可以接受
senshinya
pushed a commit
to senshinya/CodeIsland
that referenced
this pull request
Apr 15, 2026
Add a behavior toggle to auto-collapse the panel only after successful click jump validation, with failure shake/sound feedback and a dedicated click-jump preview animation aligned with mouse-leave sizing/timing.
nguyenvanduocit
pushed a commit
to nguyenvanduocit/CodeIsland
that referenced
this pull request
Apr 16, 2026
… T-030, T-031) - CLAUDE.md: add April 16 scout entry; note v1.0.20 was missed in Apr 15 scout - T-027: PR wxtsky#86 merged Apr 15 — remove "watch" blocker, ready to implement - T-029: upstream fix found in v1.0.20 (48520de) — single-line deletion in TerminalActivator.swift:98; demoted effort from S to XS - T-030 (new, XS, high): bump stuck-session idle threshold 60s → 300s for unmonitored/no-tool sessions (48520de AppState.swift fix) - T-031 (new, S, medium, watch): dismiss flow for permission prompts (PR wxtsky#93 open) https://claude.ai/code/session_016nRzjAcEvsWDCt2nFtT3DN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Summary
autoCollapseAfterSessionJump(默认关闭)。sessionList/completionCard场景)。Changed Files
Sources/CodeIsland/NotchPanelView.swiftSources/CodeIsland/Settings.swiftSources/CodeIsland/SettingsView.swiftSources/CodeIsland/L10n.swiftTests/CodeIslandTests/NotchPanelViewTests.swiftTest Plan
NotchPanelViewTests)