Skip to content

feature: add configurable auto-collapse after session jump#86

Merged
wxtsky merged 1 commit intowxtsky:mainfrom
lkangd:feature/add-click-collapse-panel
Apr 15, 2026
Merged

feature: add configurable auto-collapse after session jump#86
wxtsky merged 1 commit intowxtsky:mainfrom
lkangd:feature/add-click-collapse-panel

Conversation

@lkangd
Copy link
Copy Markdown
Contributor

@lkangd lkangd commented Apr 14, 2026

Problem

  • 在面板点击会话跳转后(当前桌面窗口),如果内容较多,会遮挡终端展示,影响整体交互流畅性。因此提供一个可选项,让用户选择点击会话后可以自动收起面板。

Summary

  • 新增配置项 autoCollapseAfterSessionJump(默认关闭)。
  • 点击会话卡片后,会异步校验是否成功切换到目标终端/客户端:
    • 成功:面板自动收起(sessionList / completionCard 场景)。
    • 失败:播放错误音效并触发抖动反馈。
  • 设置页新增对应开关与点击跳转预览动画。
  • 新增单元测试覆盖跳转校验、失败反馈序列与预览时间线关键断点。

Changed Files

  • Sources/CodeIsland/NotchPanelView.swift
  • Sources/CodeIsland/Settings.swift
  • Sources/CodeIsland/SettingsView.swift
  • Sources/CodeIsland/L10n.swift
  • Tests/CodeIslandTests/NotchPanelViewTests.swift

Test Plan

  • 单元测试通过(NotchPanelViewTests
  • 开启开关后,成功跳转会话时面板自动收起
  • 跳转失败时出现错误音效 + 抖动
  • 远程会话不触发自动收起
  • 设置页预览动画时序与循环正常

Add a behavior toggle to auto-collapse the panel only after successful click jump validation, with failure shake/sound feedback and a dedicated click-jump preview animation aligned with mouse-leave sizing/timing.
@lkangd lkangd changed the title feat: add configurable auto-collapse after session jump feature: add configurable auto-collapse after session jump Apr 14, 2026
nguyenvanduocit pushed a commit to nguyenvanduocit/CodeIsland that referenced this pull request Apr 15, 2026
- PR wxtsky#80 MERGED: configurable notch height modes → T-026
- PR wxtsky#86 open: auto-collapse after session jump → T-027 (watch)
- PR wxtsky#76 open: message input bar + TerminalWriter → T-028 (watch)
- Issue wxtsky#84: Ghostty quick terminal activation bug → T-029
- Note PR wxtsky#69 and wxtsky#70 now merged upstream (T-024, T-025 ready)
- vibe-island: no new code changes

https://claude.ai/code/session_01Hoa4hooNsWEnv8vC42x8G3
Copy link
Copy Markdown
Owner

@wxtsky wxtsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 功能完整,默认关闭不影响现有用户。

亮点:

  1. evaluateJumpValidation 设计好——依赖注入 isCancelled/sleep/checkSucceeded,方便测试
  2. 失败反馈体验好:错误音效 + 抖动动画
  3. 远程会话跳过自动收起(合理)
  4. 设置页预览动画完整,循环 seam smooth
  5. 测试覆盖全面:成功/失败/取消/动画时间线关键帧

小 nit(不阻塞):

  • jumpFailureShakeSequence()shouldTriggerJumpFailureFeedback() 是 module-level 而非 private,理解是为了测试可见性,可以接受

@wxtsky wxtsky merged commit 1f9618b into wxtsky:main Apr 15, 2026
senshinya pushed a commit to senshinya/CodeIsland that referenced this pull request Apr 15, 2026
Add a behavior toggle to auto-collapse the panel only after successful click jump validation, with failure shake/sound feedback and a dedicated click-jump preview animation aligned with mouse-leave sizing/timing.
nguyenvanduocit pushed a commit to nguyenvanduocit/CodeIsland that referenced this pull request Apr 16, 2026
… T-030, T-031)

- CLAUDE.md: add April 16 scout entry; note v1.0.20 was missed in Apr 15 scout
- T-027: PR wxtsky#86 merged Apr 15 — remove "watch" blocker, ready to implement
- T-029: upstream fix found in v1.0.20 (48520de) — single-line deletion in
  TerminalActivator.swift:98; demoted effort from S to XS
- T-030 (new, XS, high): bump stuck-session idle threshold 60s → 300s for
  unmonitored/no-tool sessions (48520de AppState.swift fix)
- T-031 (new, S, medium, watch): dismiss flow for permission prompts (PR wxtsky#93 open)

https://claude.ai/code/session_016nRzjAcEvsWDCt2nFtT3DN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants