Skip to content

feat: add TraeCli hooks support with PID tracking and improved approv…#98

Merged
wxtsky merged 1 commit intowxtsky:mainfrom
liushaoxiong10:main
Apr 16, 2026
Merged

feat: add TraeCli hooks support with PID tracking and improved approv…#98
wxtsky merged 1 commit intowxtsky:mainfrom
liushaoxiong10:main

Conversation

@liushaoxiong10
Copy link
Copy Markdown
Contributor

…al UX

  • Add TraeCli as a supported hook source
  • Install/remove managed hooks in ~/.trae/traecli.yaml without relying on marker comments
  • Normalize snake_case events and resolve tracked PID through sh wrappers
  • Ensure queued PermissionRequests keep the first item visible
  • Extend unit tests to cover merging hooks, routing, and PID resolution

…, session preservation, and approval UX

- Add TraeCli as a supported hook source for installing/removing managed hooks
- Use command signature matching instead of comment markers for hook removal
- Handle YAML flow sequences (hooks: []) to avoid invalid YAML output
- Support quoted paths with spaces in bridge command matching
- Remove adjacent comment lines when removing managed hooks
- Fix typo: treacli → traecli in RemoteInstaller
- When user is browsing session list and approval request arrives, keep
  them on the session list instead of jumping to the approval card
- Add inline approval buttons (Allow/Always/Deny) on the session card
- Normalize snake_case events and resolve tracked PID through sh wrappers
- Use atomic file writes to prevent corruption on write failure
- Add comprehensive tests for idempotency, edge cases, session-list-keeping
  behavior, and approval summary
@wxtsky wxtsky merged commit 6139c10 into wxtsky:main Apr 16, 2026
wxtsky added a commit that referenced this pull request Apr 16, 2026
- Fix .gitignore globs (.log/.tmp → *.log/*.tmp) and restore dev.sh ignore
- Localize hardcoded approval queue labels and action buttons in session list
- Drop trailing whitespace in traecli event table

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
wxtsky added a commit that referenced this pull request Apr 16, 2026
- Add approval_queue_label / approval_details_expand / approval_details_collapse
  for ja and ko so the key-parity tests pass after #72 was merged on top of #98
- Update about_desc2 from 10 to 11 across all five languages to reflect the
  TraeCli addition in #98

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
wxtsky added a commit that referenced this pull request Apr 16, 2026
The #98 merge updated the Features bullet but left the intro paragraph at 10.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants