Fetch OON retweet originals at TimelineHomeRecommendations - #116
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Fetch OON retweet originals at TimelineHomeRecommendations#116Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
Author
|
Closing: not a serving bug on the wired Phoenix path. OONRetweetReplyFilter already drops in_network==false retweets before VF, so retweet originals never reach VFCandidateHydrator as OON wrappers. Following quotes/ancestors remain the live hole (PR 115). |
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
For You VF always fetches
retweeted_tweet_idatTimelineHome, even when the wrapper is out-of-network. Quoted ids already go toTimelineHomeRecommendations.OON-only Drop rules (
NSFW_HIGH_PRECISION,DO_NOT_AMPLIFY, spam-high-recall, ...) are Interstitial on Home and Drop on Recs.should_drop_ancillaryonly dropsAction::Drop.AncillaryVFFilterthen keeps the OON retweet.VFCandidateHydratorpushes everyretweeted_tweet_idontoin_network_idsAncillaryVFFilterquoted_tweet_idis already on the Recs vecThis is not PR 55 (dual-role merge of the same id as primary and ancestor). This is not PR 90. This is not the Following hydrator (that is a separate PR). In-network retweets stay on Home.
Fix
If the wrapper is in-network, keep the original on Home. If the wrapper is OON, fetch the original at Recs.
Tests
drop_ancillary_posts = true; original fetched only at Recscargo: cannot run. Public dump has no Home Mixer manifest.