Stop For You from stamping OON before TES fills author_id - #128
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Stop For You from stamping OON before TES fills author_id#128Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
For You was classifying follow-graph membership before CoreData wrote author_id. TweetMixer often ships 0; that stamped OON and Recs-only VF drops then hit followed authors. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/in-network-after-core-data-f02e
branch
from
September 7, 2026 04:12
a5d787a to
cb9d627
Compare
This was referenced Sep 7, 2026
Closed
Closed
cursor Bot
pushed a commit
to Pitchfork-and-Torch/x-algorithm
that referenced
this pull request
Sep 7, 2026
xai-org#128 runs InNetwork after CoreData so TES can fill author_id. CoreData only wrote author_id when the source field was 0. Phoenix and Thunder ship a nonzero id. TES ran and was discarded. InNetwork stamped the source id. A followed TES author then hit TimelineHomeRecommendations. NSFW HP / gore / card Recs-drop; the same labels are interstitial on TimelineHome. TES author now overwrites a nonzero source id. TES miss still keeps source. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
For You (phoenix_candidate_pipeline) runs InNetworkCandidateHydrator before CoreDataCandidateHydrator. InNetwork reads author_id and writes in_network once.
TweetMixer often ships author_id = 0. InNetwork treats 0 as unfollowed and stamps in_network = Some(false). TES later writes the real author. The flag stays false.
VF then fetches at TimelineHomeRecommendations. Recs-only Drop rules fire (DO_NOT_AMPLIFY, SPAM_HIGH_RECALL, NSFW_HIGH_RECALL, MALICIOUS_URL, FOSNR_ABUSE_INSULTS, and the rest of the Recs table). The same followed author on Home is Allow (or Interstitial for NSFW HP / gore / card).
phoenix_scores_pipeline already runs CoreData, then InNetwork.
Fix
Run CoreData, then InNetwork, same as the scores pipeline.
This is not rewriting Recs-only policy. Not #115 / #116 / #119.