Add memory guard to flow_direction_mfd numpy/cupy backends#1424
Merged
brendancol merged 1 commit intomainfrom May 4, 2026
Merged
Add memory guard to flow_direction_mfd numpy/cupy backends#1424brendancol merged 1 commit intomainfrom
brendancol merged 1 commit intomainfrom
Conversation
The (8, H, W) float64 fractions buffer is an 8x amplifier on top of the input raster. Without a guard, a 50000x50000 DEM asks for ~100 GB silently before any error. Port the _check_memory / _check_gpu_memory helpers from flow_accumulation_mfd (64 bytes/pixel budget, 50% threshold) and call them from _run_numpy and _run_cupy. Dask paths process per-chunk through map_overlap and inherit the per-chunk guard.
brendancol
added a commit
that referenced
this pull request
May 3, 2026
Records the 11 PRs filed this round: - hydro: HIGH flow_direction_mfd memory guard (PR #1424); MEDIUM bundles for _validate_raster on secondary args (#1426), scalar param validation (#1428), and cellsize validation (#1430). - reproject: MEDIUM bundles for _validate_raster (#1432), grid/bounds/ precision validation (#1434), and NaN/Inf rejection (#1436). - flood: mannings_n DataArray validation (#1438). - pathfinding: waypoint cap + _validate_raster (#1440). - polygonize: _validate_raster (#1442). - terrain: scratch memory guard + scalar validation (#1444).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1423.
Summary
flow_direction_mfdallocates an(8, H, W)float64 buffer (64 B/px) on numpy and cupy with no memory guard. A 50000x50000 DEM asks for ~100 GB before erroring out._check_memory/_check_gpu_memoryhelpers fromflow_accumulation_mfd(64 B/px, 50% threshold) and call them from_run_numpyand_run_cupy.map_overlapand inherit the per-chunk guard via_cpu.Test plan
pytest xrspatial/hydro/tests/test_flow_direction_mfd.py— 50 passed (4 new memory-guard tests + 46 existing).