reproject: validate grid/bounds/precision params#1434
Merged
brendancol merged 2 commits intomainfrom May 4, 2026
Merged
Conversation
reproject() and merge() accept several user-controlled grid parameters that previously raised ZeroDivisionError or IndexError deep in the resampler, or silently produced backwards coords: - resolution=0 / NaN / Inf / negative: ZeroDivisionError or wrong- signed res_x. - width / height = 0 / negative: ZeroDivisionError or silently inverted output. - bounds with right<=left or top<=bottom: produced descending output coords and all-nodata silently. - transform_precision=-1: IndexError on empty np.linspace. Add _validate_grid_params() helper in _grid.py and call from both reproject() and merge() before any helper consumes these values. 24 new tests in TestValidateGridParams / TestValidateMergeGridParams.
brendancol
added a commit
that referenced
this pull request
May 3, 2026
Records the 11 PRs filed this round: - hydro: HIGH flow_direction_mfd memory guard (PR #1424); MEDIUM bundles for _validate_raster on secondary args (#1426), scalar param validation (#1428), and cellsize validation (#1430). - reproject: MEDIUM bundles for _validate_raster (#1432), grid/bounds/ precision validation (#1434), and NaN/Inf rejection (#1436). - flood: mannings_n DataArray validation (#1438). - pathfinding: waypoint cap + _validate_raster (#1440). - polygonize: _validate_raster (#1442). - terrain: scratch memory guard + scalar validation (#1444).
Contributor
Author
|
@copilot can you fix the merge conflict? |
Co-authored-by: brendancol <433221+brendancol@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1433.
Summary
_validate_grid_params()helper inxrspatial/reproject/_grid.pythat range-checksresolution,bounds,width,height,transform_precision.reproject()andmerge()(the latter only validates the params that reach it).ValueErrorfrom the public API instead ofZeroDivisionError/IndexErrordeep in the resampler or silently producing wrong-signed coords.Test plan
TestValidateGridParams/TestValidateMergeGridParams.pytest xrspatial/tests/test_reproject.py— 120 passed (96 existing + 24 new).