reproject: reject NaN/Inf in scalar inputs#1436
Merged
brendancol merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
- itrf_transform(): require finite epoch and non-empty src/tgt strings. NaN epoch silently produced all-NaN output; Inf overflowed to garbage. - geoid_height(): require finite lon/lat and lat in [-90, 90]. NaN/Inf lon/lat wrapped via int() + modulo into bogus indices, returning plausible-looking-but-wrong N values. All four convert helpers (ellipsoidal/orthometric/depth) inherit this fix. - _detect_nodata(): reject Inf (NaN remains the canonical sentinel). Inf nodata broke downstream np.isnan masks. 16 new tests in TestItrfFiniteness, TestGeoidFiniteness, TestNodataFiniteness.
brendancol
added a commit
that referenced
this pull request
May 3, 2026
Records the 11 PRs filed this round: - hydro: HIGH flow_direction_mfd memory guard (PR #1424); MEDIUM bundles for _validate_raster on secondary args (#1426), scalar param validation (#1428), and cellsize validation (#1430). - reproject: MEDIUM bundles for _validate_raster (#1432), grid/bounds/ precision validation (#1434), and NaN/Inf rejection (#1436). - flood: mannings_n DataArray validation (#1438). - pathfinding: waypoint cap + _validate_raster (#1440). - polygonize: _validate_raster (#1442). - terrain: scratch memory guard + scalar validation (#1444).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1435.
Summary
itrf_transform()rejects non-finiteepochand emptysrc/tgtstrings.geoid_height()rejects non-finitelon/lat(covers all four convert helpers transitively) and boundslatto[-90, 90]._detect_nodata()rejectsnodata=+/-Inf(NaN still allowed).Each case previously silently produced wrong output (NaN/garbage in coords, plausible-looking-but-wrong geoid undulation, or downstream
np.isnanmask failures).Test plan
TestItrfFiniteness,TestGeoidFiniteness,TestNodataFiniteness.