Skip to content

Update badge link for XGo project in README - #2249

Merged
xushiwei merged 1 commit into
mainfrom
xushiwei-patch-1
Jul 31, 2026
Merged

Update badge link for XGo project in README#2249
xushiwei merged 1 commit into
mainfrom
xushiwei-patch-1

Conversation

@xushiwei

Copy link
Copy Markdown
Contributor

No description provided.

@xushiwei
xushiwei merged commit b81214e into main Jul 31, 2026
33 of 34 checks passed
@xushiwei
xushiwei deleted the xushiwei-patch-1 branch July 31, 2026 21:46

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Update badge link for XGo project in README

The one-line change on README.md:8 is correct. Renaming the badge label language-XGoproject-XGo (and alt text LanguageXGo) better reflects that XGo is the parent project rather than a language attribute of LLGo, and the link target github.com/goplus/xgo is well-formed and unchanged. The shields.io URL, color, and Markdown syntax are all valid.

No blocking issues found across correctness, security, performance, and documentation-accuracy passes.

Minor, out of scope (non-blocking): the prose a couple of lines below — README.md:10, "It's a subproject of the XGo project" — still links to the old goplus/gop path, while this badge now uses goplus/xgo. Both currently resolve to the same repo via GitHub's rename redirect, so nothing is broken, but aligning the prose link to goplus/xgo would make the two XGo references in the same paragraph consistent and future-proof against the redirect being removed.

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant