Parent attribute argument spans before lowering [isolated: +0.07% suite, neutral; base of #93] - #89
Draft
xmakro wants to merge 1 commit into
Draft
Parent attribute argument spans before lowering [isolated: +0.07% suite, neutral; base of #93]#89xmakro wants to merge 1 commit into
xmakro wants to merge 1 commit into
Conversation
This was referenced Aug 4, 2026
xmakro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attribute argument tokens reached the incremental hash with raw, unparented spans:
parse_attribute_listcalledArgParser::from_attr_argswithoutlower_span, andlower_attr_argscloned the args as-is. Any position shift above an attributed item therefore churned the item's hash.This adds
TokenStream::map_spansand parents the argument token spans before parsing and lowering, gated on incremental builds. Isolated on the 6-crate suite this is neutral (the extra token pass costs about what the hashing saves); its value is span-shift resilience for attributed items and themap_spansutility that #93 builds on.