Add azuresql scheme - #21
Conversation
|
I'm OK with adding additional aliases (when they make sense), and this is probably acceptable. Can you please rebase these commits into a single commit? This is a trivial change, and the repo doesn't need 3 separate commits for this. |
3adaf8e to
3daae56
Compare
|
Hi @kenshaw, it wasn't ready for review at that time. What do you think? |
|
@burningalchemist so my concern here is that after reading the documentation, this appears to also require changing to Microsoft's version of the package. I'm OK with that, in principle (assuming Microsoft actually plans to maintain the package), but the drivers need to be switched out in |
|
Quick note: for |
|
The new package is maintained by the same people, it's also back compatible, so there should be no issues. I use I'm happy to update UPD: I checked the original repo, and the Azure AD authentication exists there as well. I think it's still a good idea to update to a maintained driver. |
Description
The whole point for adding
azuresqlalias is that recently Microsoft took the ownership forgo-mssqldbdriver, and by chance they also implemented Azure AD authentication, which implies that on the application side we:azuread;azuresqlas a scheme.The rest stays the same, so it seems to be a low hanging fruit.
Reference link: https://github.com/microsoft/go-mssqldb#azure-active-directory-authentication