Skip to content

Update go-mssqldb driver reference - #365

Closed
burningalchemist wants to merge 1 commit into
xo:masterfrom
burningalchemist:go-mssqldb
Closed

Update go-mssqldb driver reference#365
burningalchemist wants to merge 1 commit into
xo:masterfrom
burningalchemist:go-mssqldb

Conversation

@burningalchemist

Copy link
Copy Markdown
Contributor

Notable changes:

  • Replace denisenkom/go-mssqldb to a maintained compatible microsoft/go-mssqldb driver;
  • Add azuresql alias.

With this change we only replace the driver and add azuresql alias for compatibility with xo and dburl modules.

To connect to MSSQL DB via Azure AD we need to import the submodule azuread. We could potentially replace microsoft/go-mssqldb with microsoft/go-mssqldb/azuread as it implicitly imports the root module and doesn't seem to have any bad implications. However, I'm not sure if it's a good idea, or we'd better treat azuresql differently.

It also might be a separate PR to keep the scope small.

References:

@nineinchnick

Copy link
Copy Markdown
Member

Looks like this has been merged in c39cb6c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants